From: Jasper St. Pierre Date: Sat, 31 Aug 2013 20:57:41 +0000 (-0400) Subject: workspace: Make sure to sort the last row in the overview X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~3560 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=b53be942d4c7edf45deeba8c9cce9bf2f49ae69c;p=gnome-shell.git workspace: Make sure to sort the last row in the overview We added special code to sort each row in the overview so that windows were less likely to cross lines, but the awkward control flow meant that everything but the last row got sorted. https://bugzilla.gnome.org/show_bug.cgi?id=707197 --- diff --git a/js/ui/workspace.js b/js/ui/workspace.js index a2716efd9..03446ba27 100644 --- a/js/ui/workspace.js +++ b/js/ui/workspace.js @@ -876,7 +876,6 @@ const UnalignedLayoutStrategy = new Lang.Class({ row.windows.push(window); row.fullWidth += width; } else { - this._sortRow(row); break; } } @@ -886,6 +885,8 @@ const UnalignedLayoutStrategy = new Lang.Class({ let maxRow; for (let i = 0; i < numRows; i++) { let row = rows[i]; + this._sortRow(row); + if (!maxRow || row.fullWidth > maxRow.fullWidth) maxRow = row; gridHeight += row.fullHeight;